Merged
Conversation
k1nho
force-pushed
the
tests/add-testing
branch
22 times, most recently
from
49ab01c to
8d277fd
Compare
k1nho
force-pushed
the
tests/add-testing
branch
6 times, most recently
from
856b318 to
c6a8f1d
Compare
k1nho
force-pushed
the
tests/add-testing
branch
6 times, most recently
from
c0f130e to
f2af07c
Compare
- Restructure project files - Add initial testing for the dashboard
k1nho
force-pushed
the
tests/add-testing
branch
from
f2af07c to
26ce9e9
Compare
jackdmarquez
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following addresses #21 by adding testing with
pytestfor theAppStateclass which is responsible for many operations during the dashboard's lifecycle.pollmethods which are the main entrypoint to dahsboard updates.last_idcritical to fetch the unique id of atransitionorandierecord.update_stateful_plot.Other changes
Changing project structure into the following.
services:for all NSDF-INTERSECT services and its utils (dashboard, service, storage, gsa_loader)clients:testing clients (realtime, single, transition)tests:for testing, currently unit tests fordashboard.pyconfig:example configs of dashboard, service, clients, and conda environment.Removes the mantid dependency, in favor of a custom parser for the gsa files. The parser was adapted for individual gsa files. After removing the mantid dependency, we shave off 1.5 GB off the image and CI builds are much easier since we do not need to change aarch64.