Build the krill and routinator docker images to be multiplatform#47
Open
Belthazaar wants to merge 4 commits intonsg-ethz:masterfrom
Open
Build the krill and routinator docker images to be multiplatform#47Belthazaar wants to merge 4 commits intonsg-ethz:masterfrom
Belthazaar wants to merge 4 commits intonsg-ethz:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the docker images for Krill and Routinator are built with a target platform: x86_64-alpine-linux-musl.
This limits the mini Internet to x86_64 systems. The goal of the PR is to match how NLnetLabs built their images (Dockerfile for Routinator) and remove platform specific commands. As part of this, the Krill and Routinator images have also been updated to the latest version, and changes have been made in the setup scripts to make them compatible.
Removing the platform specific requirements also means that the mini Internet project can now run in a VM on a Apple Silicone based Mac.