-
Notifications
You must be signed in to change notification settings - Fork 42
Is2 ecs decom #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is2 ecs decom #97
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…ECS. Edited readme and notebook with note that this was for a workshop and would not be further updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I would just add a dash in "on premises" and remove the ".html" from the second link.
| "nbconvert_exporter": "python", | ||
| "pygments_lexer": "ipython3", | ||
| "version": "3.10.14" | ||
| "version": "3.9.18" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one actually downgraded from 3.10.14 to 3.9.18? Others went from 3.9.16 to 3.9.18 (?)
| @@ -0,0 +1,558 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this is a copy and paste of a functional script to create a new file so all is well!
| "metadata": {}, | ||
| "source": [ | ||
| "Then we use a spatial filter to search for ATL10 granules that intersect our area of interest. This is the same area we used in our cs2eo query above." | ||
| "Locate the ATL10 urls in the ATL10 download script provided by cs2eo (ATL10_V6_download_script.py). Copy the cloudfront urls from the script into a list, as below. " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shift looks to cloudfront URLs seems fine, but I'm not being exacting.
@frizatch would you mind taking a quick look?