-
Notifications
You must be signed in to change notification settings - Fork 132
Move repo decision record - updates from 9-30 hackday! #1104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
asteiker
wants to merge
5
commits into
nsidc:move-repo-decision-record
Choose a base branch
from
asteiker:move-repo-decision-record
base: move-repo-decision-record
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3716700
add pros cons and historical context
d4ab72c
add migration impacts
b5cf123
Update docs/governance/decisions/929-move-repository.md
asteiker f59a7e0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 5ef7d54
Typo fixes
mfisher87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we get all of the above from e.g. going through pyopensci review without being in a special org. I wouldn't describe these benefits as unique to being in a specific org.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great point, @mfisher87 ! Should I rework this to incorporate pyopensci review as a new process we would incorporate as part of either/both Option 2 and 3? If you have more details on how this could work, please let me know.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard to decide how to organize this information... it's not really tied to option 2 or 3. It could apply to any of options 1, 2, or 3, and it confers the same pros from option 3. So I think this is an independent variable that should not be documented as part of this decision record, and perhaps should be another decision. I.e. remove the unique pros from option 3 as they are not conferred solely by joining a third-party org and can be conferred through other processes.
What do you think?