Skip to content

Conversation

@mfisher87
Copy link
Collaborator

@mfisher87 mfisher87 commented Nov 12, 2025

This list is being interrupted by a paragraph, and that's definitely not what we intended!

image

I'm used to needing to match the indent of the first character of the list item, e.g.:

1. Foo

I should need to indent 3 spaces because the character F is at position 3. It just looks better in my editor that way, too.

Mkdocs seems to require 4 spaces. 🤷

Pull Request (PR) draft checklist - click to expand
  • Please review our
    contributing documentation
    before getting started.
  • Populate a descriptive title. For example, instead of "Updated README.md", use a
    title such as "Add testing details to the contributor section of the README".
    Example PRs: #763
  • Populate the body of the pull request with:
  • Update CHANGELOG.md with details about your change in a section titled
    ## Unreleased. If such a section does not exist, please create one. Follow
    Common Changelog for your additions.
    Example PRs: #763
  • Update the documentation and/or the README.md with details of changes to the
    earthaccess interface, if any. Consider new environment variables, function names,
    decorators, etc.

Click the "Ready for review" button at the bottom of the "Conversation" tab in GitHub
once these requirements are fulfilled. Don't worry if you see any test failures in
GitHub at this point!

Pull Request (PR) merge checklist - click to expand

Please do your best to complete these requirements! If you need help with any of these
requirements, you can ping the @nsidc/earthaccess-support team in a comment and we
will help you out!

  • Add unit tests for any new features.
  • Apply formatting and linting autofixes. You can add a GitHub comment in this Pull
    Request containing "pre-commit.ci autofix" to automate this.
  • Ensure all automated PR checks (seen at the bottom of the "conversation" tab) pass.
  • Get at least one approving review.

📚 Documentation preview 📚: https://earthaccess--1138.org.readthedocs.build/en/1138/

I'm used to needing to match the indent of the first character of the
list item, e.g.:

```
1. Foo
```

I should need to indent 3 spaces because the character `F` is at
position 3. It just looks better in my editor that way, too.

Mkdocs seems to require 4 spaces. 🤷
@github-actions
Copy link

Binder 👈 Launch a binder notebook on this branch for commit e192e13

I will automatically update this comment whenever this PR is modified

@mfisher87 mfisher87 added the impact: documentation Improvements or additions to documentation label Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

impact: documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants