Skip to content

Prevent formatting symlink file #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+23 −0
Open

Prevent formatting symlink file #1144

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1a7922d
Prevent fixing symlink file
ana-sher Nov 14, 2025
906cf98
Revert pre-commit auto changes
ana-sher Nov 14, 2025
05fbfba
Merge branch 'main' into 1143-pre-commit-hook-win-bug
ana-sher Nov 14, 2025
23fb596
Avoid running yamlfmt on Windows
ana-sher Nov 15, 2025
b2f30e4
Merge branch '1143-pre-commit-hook-win-bug' of https://github.com/ana…
ana-sher Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,19 @@ repos:
exclude: ".*/vcr_cassettes/.*\\.yaml"
- id: check-toml
- id: check-json
# Check for common mistakes
- id: check-added-large-files
# Check for common mistakes
Copy link
Collaborator

@chuckwondo chuckwondo Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ana-sher! It looks like you may have forgotten to skip the yamlfmt hook when you committed your change, but I think that's because you used VSCode to commit this change, rather than making the commit from the command line, where you would be able to specify SKIP.

Can you revert the changes in this file, other than the single line for excluding docs/LICENSE.txt?

Copy link
Author

@ana-sher ana-sher Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chuckwondo, yes, that's exactly what happened 💯 Reverted and fixed by running from the command line.

- id: check-case-conflict
# - id: check-illegal-windows-names # TODO: Enable in next release
- id: check-merge-conflict
# - id: check-illegal-windows-names # TODO: Enable in next release
- id: check-executables-have-shebangs
- id: check-shebang-scripts-are-executable
- id: check-symlinks
- id: check-vcs-permalinks
- id: destroyed-symlinks
- id: detect-private-key
- id: end-of-file-fixer
exclude: docs/LICENSE.txt
- id: mixed-line-ending
- id: no-commit-to-branch # protects `main` by default
- id: trailing-whitespace
Expand Down