Skip to content

Conversation

@JessicaS11
Copy link
Collaborator

@JessicaS11 JessicaS11 commented Feb 19, 2024

When working on #424, I noticed a few of the newer api functions weren't being imported because they hadn't been added to the list in __init__.py. I update the list and added comments of which modules they're from for clarity. I'm wondering what the incentive for lines 5-17 is (versus from .api import *, with the acknowledgement that *isn't best practice - so perhaps there's a better solution) so two manual lists of the functions in .api don't need to be maintained.

This work is currently included in #424, but I figured separating it out would be clearer.


📚 Documentation preview 📚: https://earthaccess--461.org.readthedocs.build/en/461/

@chuckwondo
Copy link
Collaborator

@JessicaS11, do you have time to address @jhkennedy's comments so we can approve and merge your contribution?

@JessicaS11
Copy link
Collaborator Author

@chuckwondo Thanks for the ping - it looks like my updates and your message crossed paths. This should be all set. I also just checked against the current api.py and the list still looks complete.

@chuckwondo chuckwondo merged commit c04199a into main May 12, 2024
@mfisher87 mfisher87 deleted the init-list branch May 12, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants