Added exception extensions for ValueTask without return type#864
Closed
marcselman wants to merge 31 commits intonsubstitute:mainfrom
Closed
Added exception extensions for ValueTask without return type#864marcselman wants to merge 31 commits intonsubstitute:mainfrom
marcselman wants to merge 31 commits intonsubstitute:mainfrom
Conversation
…the test TestSubstituteWithAsynchronousHandler does not work because of the bug
… unit tests to verify error conditions * Rename unit tests with better description * Fix unit test failure due to orphaned argument spec when previous setup throws
… is a generic argument in the return type
…s when AnyType is a generic argument in the out or ref parameter
Ability to mock protected methods with and without return value
Enable nullability for public api
…nt-handlers-return-instantly Bugfix/async event handlers return instantly
…pe-matching Fix matching generic calls with AnyType when the generic argument is also a generic argument in return type, out or ref parameter
Feature: allow interception of any generic method call when using Arg.AnyType
Member
|
Thanks @marcselman ! Would you be able to rebase this on to latest |
Author
|
@dtchepak Rebased and formatting fixed! |
Member
|
Thanks @marcselman ! For some reason additional commits are listed. I've tried tidying up the commit history. Could you please take a look and make sure it looks like your changes are intact on this branch? #873 |
Author
|
Hi @dtchepak. I checked the branch against my earlier commit and those are the exact changes. |
Member
|
Thanks @marcselman . Will close this and merge #873 once I get the required reviews. Alternatively you can re-open and update this PR with the changes from 873 and then I can review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of the
ThrowsAsyncandThrowsAsyncForAnyArgsextension methods work for work forTask(void),Task<T>andValueTask<T>but not forValueTask(void).This change implements the extension methods and includes all related tests.