Make public api and tests the same for all TFMs#885
Merged
Romfos merged 4 commits intonsubstitute:mainfrom Jul 13, 2025
Merged
Conversation
26 tasks
dtchepak
approved these changes
Jun 9, 2025
dtchepak
approved these changes
Jun 9, 2025
dtchepak
approved these changes
Jul 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Motivation:
Some public api is not available for for .NET Standard in current implementation.
Problem is that ValueTask is a core type in modern dotnet ecosystem. A lot of popular libraries using it.
Make sense to remove this gap and make public api the same for all platforms
Why System.Threading.Tasks.Extensions was updated?
Old version doesn't have non-generic ValueTask type