Skip to content

Commit 67393f5

Browse files
authored
fix: recognize api.atlassian.com as Cloud URL for Multi-Cloud OAuth (sooperset#561)
- Add api.atlassian.com to Cloud URL detection pattern - Fixes email-based user lookups in Multi-Cloud OAuth mode - Add test coverage for Multi-Cloud OAuth URL pattern Reported-by: MuhammadAli-208 Github-Issue: sooperset#560
1 parent c62d76b commit 67393f5

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

src/mcp_atlassian/utils/urls.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,4 +35,5 @@ def is_atlassian_cloud_url(url: str) -> bool:
3535
".atlassian.net" in hostname
3636
or ".jira.com" in hostname
3737
or ".jira-dev.com" in hostname
38+
or "api.atlassian.com" in hostname
3839
)

tests/unit/utils/test_urls.py

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,21 @@ def test_is_atlassian_cloud_url_cloud():
2222
assert is_atlassian_cloud_url("https://team.jira-dev.com") is True
2323

2424

25+
def test_is_atlassian_cloud_url_multi_cloud_oauth():
26+
"""Test that is_atlassian_cloud_url returns True for Multi-Cloud OAuth URLs."""
27+
# Test api.atlassian.com URLs used by Multi-Cloud OAuth
28+
assert (
29+
is_atlassian_cloud_url("https://api.atlassian.com/ex/jira/abc123/rest/api/2/")
30+
is True
31+
)
32+
assert (
33+
is_atlassian_cloud_url("https://api.atlassian.com/ex/confluence/xyz789/")
34+
is True
35+
)
36+
assert is_atlassian_cloud_url("http://api.atlassian.com/ex/jira/test/") is True
37+
assert is_atlassian_cloud_url("https://api.atlassian.com") is True
38+
39+
2540
def test_is_atlassian_cloud_url_server():
2641
"""Test that is_atlassian_cloud_url returns False for Atlassian Server/Data Center URLs."""
2742
# Test with various server/data center domains

0 commit comments

Comments
 (0)