fix: quote project names in JQL queries to handle reserved keywords (sooperset#553)

Quote project names in JQL queries to prevent syntax errors when project
keys match JQL reserved keywords (e.g., "AND", "OR", "IN").

Previously, queries like `project = AND` would fail with a JQL parsing
error. Now properly quoted as `project = "AND"`.

Changes:
- Quote project keys in get_project_issues_count() and get_project_issues()
- Quote single project in search_issues() filter
- Add test case for reserved keyword project names
- Update all affected test assertions

This ensures JQL queries work correctly regardless of project naming.

Reported-by: Amichai Schreiber
Github-Issue: sooperset#553

Author: amichai-gloat

src/mcp_atlassian/jira/projects.py

@@ -283,7 +283,7 @@ def get_project_issues_count(self, project_key: str) -> int:
         """
         try:
             # Use JQL to count issues in the project
-            jql = f"project = {project_key}"
+            jql = f'project = "{project_key}"'
             result = self.jira.jql(jql=jql, fields="key", limit=1)
             if not isinstance(result, dict):
                 msg = f"Unexpected return value type from `jira.jql`: {type(result)}"
@@ -319,7 +319,7 @@ def get_project_issues(
         """
         try:
             # Use JQL to get issues in the project
-            jql = f"project = {project_key}"
+            jql = f'project = "{project_key}"'
 
             return self.search_issues(jql, start=start, limit=limit)
 

src/mcp_atlassian/jira/search.py

@@ -57,7 +57,7 @@ def search_issues(
 
                 # Build the project filter query part
                 if len(projects) == 1:
-                    project_query = f"project = {projects[0]}"
+                    project_query = f'project = "{projects[0]}"'
                 else:
                     quoted_projects = [f'"{p}"' for p in projects]
                     projects_list = ", ".join(quoted_projects)

tests/unit/jira/test_projects.py

@@ -166,7 +166,7 @@ def test_get_project_issues(projects_mixin: ProjectsMixin):
 
     # Verify search_issues was called, not jira.jql
     projects_mixin.search_issues.assert_called_once_with(
-        "project = TEST",
+        'project = "TEST"',
         start=0,
         limit=50,
     )
@@ -201,7 +201,7 @@ def test_get_project_issues_with_start(projects_mixin: ProjectsMixin) -> None:
 
     # Verify search_issues was called with the correct arguments
     projects_mixin.search_issues.assert_called_once_with(
-        f"project = {project_key}",
+        f'project = "{project_key}"',
         start=start_index,
         limit=5,
     )
@@ -468,7 +468,21 @@ def test_get_project_issues_count(projects_mixin: ProjectsMixin):
     result = projects_mixin.get_project_issues_count("PROJ1")
     assert result == 42
     projects_mixin.jira.jql.assert_called_once_with(
-        jql="project = PROJ1", fields="key", limit=1
+        jql='project = "PROJ1"', fields="key", limit=1
+    )
+
+
+def test_get_project_issues_count__project_with_reserved_keyword(
+    projects_mixin: ProjectsMixin,
+):
+    """Test get_project_issues_count method."""
+    jql_result = {"total": 42}
+    projects_mixin.jira.jql.return_value = jql_result
+
+    result = projects_mixin.get_project_issues_count("AND")
+    assert result == 42
+    projects_mixin.jira.jql.assert_called_once_with(
+        jql='project = "AND"', fields="key", limit=1
     )
 
 
@@ -508,7 +522,7 @@ def test_get_project_issues_with_search_mixin(projects_mixin: ProjectsMixin):
     result = projects_mixin.get_project_issues("PROJ1", start=10, limit=20)
     assert result == mock_search_result
     projects_mixin.search_issues.assert_called_once_with(
-        "project = PROJ1", start=10, limit=20
+        'project = "PROJ1"', start=10, limit=20
     )
     projects_mixin.jira.jql.assert_not_called()
 

tests/unit/jira/test_search.py

@@ -291,7 +291,7 @@ def test_search_issues_with_projects_filter(self, search_mixin: SearchMixin):
         # Test with single project filter
         result = search_mixin.search_issues("text ~ 'test'", projects_filter="TEST")
         search_mixin.jira.jql.assert_called_with(
-            "(text ~ 'test') AND project = TEST",
+            "(text ~ 'test') AND project = \"TEST\"",
             fields=ANY,
             start=0,
             limit=50,
@@ -350,7 +350,7 @@ def test_search_issues_with_config_projects_filter(self, search_mixin: SearchMix
         # Test with override
         result = search_mixin.search_issues("text ~ 'test'", projects_filter="OVERRIDE")
         search_mixin.jira.jql.assert_called_with(
-            "(text ~ 'test') AND project = OVERRIDE",
+            "(text ~ 'test') AND project = \"OVERRIDE\"",
             fields=ANY,
             start=0,
             limit=50,
@@ -604,7 +604,7 @@ def test_search_issues_with_projects_filter_jql_construction(
 
         # Assert: JQL verification
         api_method_mock.assert_called_with(
-            "(text ~ 'test') AND project = TEST",  # Check constructed JQL
+            "(text ~ 'test') AND project = \"TEST\"",  # Check constructed JQL
             **expected_kwargs,
         )
 
@@ -670,5 +670,5 @@ def test_search_issues_with_config_projects_filter_jql_construction(
         search_mixin.search_issues("text ~ 'test'", projects_filter="OVERRIDE")
         # Assert: JQL verification
         api_method_mock.assert_called_with(
-            "(text ~ 'test') AND project = OVERRIDE", **expected_kwargs
+            "(text ~ 'test') AND project = \"OVERRIDE\"", **expected_kwargs
         )