Skip to content

Add Python 3.14 support #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
costajohnt wants to merge 1 commit into
base: main
Choose a base branch
from
+36 −17
Open

Add Python 3.14 support #867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ jobs:
name: "Python ${{ matrix.python-version }}"
runs-on: "ubuntu-latest"
env:
USING_COVERAGE: '3.10,3.11,3.12,3.13'
USING_COVERAGE: '3.10,3.11,3.12,3.13,3.14'

strategy:
fail-fast: false
matrix:
python-version: ["3.10", "3.11", "3.12", "3.13"]
python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]

steps:
- uses: "actions/checkout@v6"
Expand Down
45 changes: 31 additions & 14 deletions papermill/tests/test_execute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,9 @@ def test(self):
self.assertRegex(nb.cells[5].source, '<span id="papermill-error-cell" .*</span>')
self.assertEqual(nb.cells[5].metadata["tags"], ["papermill-error-cell-tag"])
self.assertEqual(nb.cells[6].execution_count, 2)
self.assertEqual(nb.cells[6].outputs[0].output_type, 'error')
# Python 3.14+ emits a stderr stream before the error output for assertion errors
output_types = [o.output_type for o in nb.cells[6].outputs]
self.assertIn('error', output_types)

self.assertEqual(nb.cells[7].execution_count, None)

Expand Down Expand Up @@ -187,8 +189,10 @@ def test(self):
self.assertEqual(nb.cells[2].cell_type, "markdown")
self.assertRegex(nb.cells[2].source, '<span id="papermill-error-cell" .*</span>')
self.assertEqual(nb.cells[3].execution_count, 2)
self.assertEqual(nb.cells[3].outputs[0].output_type, 'display_data')
self.assertEqual(nb.cells[3].outputs[1].output_type, 'error')
# Python 3.14+ may insert a stderr stream between display_data and error outputs
output_types = [o.output_type for o in nb.cells[3].outputs]
self.assertIn('display_data', output_types)
self.assertIn('error', output_types)

self.assertEqual(nb.cells[4].execution_count, None)

Expand Down Expand Up @@ -279,9 +283,12 @@ def test_sys_exit(self):
self.assertEqual(nb.cells[0].cell_type, "code")
self.assertEqual(nb.cells[0].execution_count, 1)
self.assertEqual(nb.cells[1].execution_count, 2)
self.assertEqual(nb.cells[1].outputs[0].output_type, 'error')
self.assertEqual(nb.cells[1].outputs[0].ename, 'SystemExit')
self.assertEqual(nb.cells[1].outputs[0].evalue, '')
# Python 3.14+ may emit a stderr stream before the error output
output_types = [o.output_type for o in nb.cells[1].outputs]
self.assertIn('error', output_types)
error_output = next(o for o in nb.cells[1].outputs if o.output_type == 'error')
self.assertEqual(error_output.ename, 'SystemExit')
self.assertEqual(error_output.evalue, '')
self.assertEqual(nb.cells[2].execution_count, None)

def test_sys_exit0(self):
Expand All @@ -292,9 +299,12 @@ def test_sys_exit0(self):
self.assertEqual(nb.cells[0].cell_type, "code")
self.assertEqual(nb.cells[0].execution_count, 1)
self.assertEqual(nb.cells[1].execution_count, 2)
self.assertEqual(nb.cells[1].outputs[0].output_type, 'error')
self.assertEqual(nb.cells[1].outputs[0].ename, 'SystemExit')
self.assertEqual(nb.cells[1].outputs[0].evalue, '0')
# Python 3.14+ may emit a stderr stream before the error output
output_types = [o.output_type for o in nb.cells[1].outputs]
self.assertIn('error', output_types)
error_output = next(o for o in nb.cells[1].outputs if o.output_type == 'error')
self.assertEqual(error_output.ename, 'SystemExit')
self.assertEqual(error_output.evalue, '0')
self.assertEqual(nb.cells[2].execution_count, None)

def test_sys_exit1(self):
Expand All @@ -310,7 +320,9 @@ def test_sys_exit1(self):
self.assertEqual(nb.cells[2].cell_type, "markdown")
self.assertRegex(nb.cells[2].source, '<span id="papermill-error-cell" .*</span>')
self.assertEqual(nb.cells[3].execution_count, 2)
self.assertEqual(nb.cells[3].outputs[0].output_type, 'error')
# Python 3.14+ may emit a stderr stream before the error output
output_types = [o.output_type for o in nb.cells[3].outputs]
self.assertIn('error', output_types)

self.assertEqual(nb.cells[4].execution_count, None)

Expand All @@ -322,9 +334,12 @@ def test_system_exit(self):
self.assertEqual(nb.cells[0].cell_type, "code")
self.assertEqual(nb.cells[0].execution_count, 1)
self.assertEqual(nb.cells[1].execution_count, 2)
self.assertEqual(nb.cells[1].outputs[0].output_type, 'error')
self.assertEqual(nb.cells[1].outputs[0].ename, 'SystemExit')
self.assertEqual(nb.cells[1].outputs[0].evalue, '')
# Python 3.14+ may emit a stderr stream before the error output
output_types = [o.output_type for o in nb.cells[1].outputs]
self.assertIn('error', output_types)
error_output = next(o for o in nb.cells[1].outputs if o.output_type == 'error')
self.assertEqual(error_output.ename, 'SystemExit')
self.assertEqual(error_output.evalue, '')
self.assertEqual(nb.cells[2].execution_count, None)

def test_line_magic_error(self):
Expand Down Expand Up @@ -456,6 +471,8 @@ def test_output_formatting(self):
self.assertEqual(nb.cells[2].cell_type, "markdown")
self.assertRegex(nb.cells[2].source, '<span id="papermill-error-cell" .*</span>')
self.assertEqual(nb.cells[3].execution_count, 2)
self.assertEqual(nb.cells[3].outputs[0].output_type, 'error')
# Python 3.14+ may emit a stderr stream before the error output
output_types = [o.output_type for o in nb.cells[3].outputs]
self.assertIn('error', output_types)

self.assertEqual(nb.cells[4].execution_count, None)
4 changes: 3 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,14 +225,15 @@ omit = [
legacy_tox_ini = """
[tox]
skipsdist = true
envlist = py{310,311,312,313}, dist, manifest, docs, binder
envlist = py{310,311,312,313,314}, dist, manifest, docs, binder

[gh-actions]
python =
3.10: py310
3.11: py311
3.12: py312
3.13: py313, docs, dist
3.14: py314

# Manifest
[testenv:manifest]
Expand Down Expand Up @@ -280,6 +281,7 @@ basepython =
py311: python3.11
py312: python3.12
py313: python3.13
py314: python3.14
manifest: python3.13
dist: python3.13
docs: python3.13
Expand Down