Add further new unit tests to cover more cases#25
Merged
Conversation
Add more unit tests for the generic framework to also cover the failing cases when creating a rootfs. In particular, add tests for the following cases: - The include field is not properly formatted - The rootfs type is unsupported Signed-off-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Add more unit tests for pasing files and test cases where the input is invalid. In particular, add the following tests: - Invalid Containerfile, which is empty and can not be parsed - Invalid file, which contains a single line Signed-off-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Add one more unit test to verify that the creation of a rootfs with an invalid format in the include files will fail. Signed-off-by: Charalampos Mainas <cmainas@nubificus.co.uk>
Add further unit tests for checking the unsupported features that a rootfs field implies in a bunnyfile. In particular add the following tests: - Non-empty path with raw rootfs type, which means that we specify both a file to use as rootfs but also set the type as raw, which will require to unpack the file and transform it to raw. This is not supported yet. - The from field equals "local" and the rootfs type is raw, which means that we have to use something local as raw, which is similar to the previous case (use a file with raw rootfs type). Again not supported yet. - The from field is not scratch and we the include field is non-empty, which means that we want to append files in an existing rootds. This is not supported yet. Signed-off-by: Charalampos Mainas <cmainas@nubificus.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add further unit tests to cover more cases when validating and parsing files, but also on creating a rootfs for Unikraft and generic frameworks.