Tests, Clearing, Fixes#207
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
==========================================
+ Coverage 82.18% 82.29% +0.10%
==========================================
Files 24 24
Lines 1774 1785 +11
Branches 242 242
==========================================
+ Hits 1458 1469 +11
Misses 172 172
Partials 144 144 🚀 New features to boost your workflow:
|
|
@MatthieuDartiailh hey, its me again |
|
Could you add a CI job to run the added C++ tests ? |
|
@MatthieuDartiailh yes, I will do it. Call tests on every commit to the main branch? How do you want it to work? |
|
Yes. You can follow the trigger used for Python jobs. However running on Linux should be enough for the C++ tests. |
|
@MatthieuDartiailh I did it. PS: Could you please take a look at why it fails with the "Generating documentation" error every time? I don't know enough Python to try to fix this. |
|
The documentation issue comes from sphinx-tabs which is incompatible with latest sphinx version. PR are open to fix the issue but have not been merged yet. |
|
What else is needed to accept this mr? |
|
@MatthieuDartiailh can you suggest anything? |
MatthieuDartiailh
left a comment
There was a problem hiding this comment.
One minor point but otherwise LGTM. Sorry for the slow review.
| @@ -1,13 +1,12 @@ | |||
| /*----------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
The commented code is there to easily check the relevance of using AssocVec vs a standard map.
I can understand the urge to remove commented out code but in this occurrence I would feel better to keep it. You may add a comment explaining why it is there.
|
Thanks ! |
|
@MatthieuDartiailh what you think about it? #207 (comment) Can you release a new version? This is necessary so that we can use 'FetchContent' with the tag. |
Added C++ tests:
Removed unused includes and commented code
Added compilation options for code verification