Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the release workflow to correctly handle cases with no previous tags (first release) and enhances the changelog with a dedicated "Breaking Changes" section.
- Introduce branching logic for first-release vs. subsequent releases in both
changesandreleasejobs - Default
LAST_TAGto empty and detect absence of tags - Append a “### Breaking Changes” section in
changelog.md
Comments suppressed due to low confidence (2)
.github/workflows/release.yml:65
- The logic to detect and initialize a first release is duplicated in both the
changesandreleasejobs. Consider extracting this into a reusable step or composite action to reduce duplication and simplify future maintenance.
if [[ -z "$LAST_TAG" ]]; then
.github/workflows/release.yml:161
- The "Breaking Changes" section is appended unconditionally. You should wrap this in a condition (e.g., only for major releases or when breaking-change commits exist) to avoid misleading empty sections in minor/patch releases.
echo "### Breaking Changes" >> changelog.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.