Skip to content

fix: Index out of range exception in Cheap Viewers rule #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2025
Merged

fix: Index out of range exception in Cheap Viewers rule #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Nullinside.Api.TwitchBot.Tests/ChatRules/BestCheapViewersTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ public class BestCheapViewersTests : AChatRuleUnitTestBase<BestCheapViewers> {
/// </summary>
/// <param name="badString">The string that should fail.</param>
[Test]
[TestCase("C\u032dheap viewe\u034crs on\u0306 vwrpro.ru @8v2JcQFL")]
[TestCase("Ch\u031ae\u0345ap viewers on *** @STGPMoLg")]
[TestCase("Best\u036e vie\u0350wers \u0337on ***")]
[TestCase("Best viewers on ***")]
[TestCase("Best viewers on ***")]
Expand Down
1 change: 1 addition & 0 deletions src/Nullinside.Api.TwitchBot.Tests/ChatRules/DoghypeTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ public class DogehypeTests : AChatRuleUnitTestBase<Dogehype> {
/// </summary>
/// <param name="badString">The string that should fail.</param>
[Test]
[TestCase("Visit dogehype dot com today and effortlessly boost your Twitch rankings! @opAzPMVt")]
[TestCase("Visit dogehype dot com and watch your channel grow today! @5MGxTnYl")]
[TestCase("Visit dogehype dot com today and climb the Twitch rankings with ease! Whether you're just starting out or looking to take your stream to the next level, DogeHype has the tools you need to succeed. @gqznceDC")]
[TestCase("Visit dogehype .biz com today and climb the Twitch rankings with ease! Whether you're just starting out or looking to take your stream to the next level, DogeHype has the tools you need to succeed. @Axxq7ntz")]
Expand Down
2 changes: 1 addition & 1 deletion src/Nullinside.Api.TwitchBot/ChatRules/BestCheapViewers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public override async Task<bool> Handle(string channelId, ITwitchApiProxy botPro
int offset = 0;
for (int i = 0; i < expected.Length; i++) {
// If this is a normal character it should be in the correct position.
if (normalized[i + offset] == expected[i]) {
if (i + offset < normalized.Length && normalized[i + offset] == expected[i]) {
++matches;
}
// If this is an accent mark then the next character should match and the whole string we're evalutating
Expand Down