Skip to content

bug: fixing issue with compiling as a single file application #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2025
Merged

bug: fixing issue with compiling as a single file application #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions src/Nullinside.Api.Common/Desktop/GitHubUpdateManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,11 @@ public static class GitHubUpdateManager {
public static async Task PrepareUpdate() {
try {
// To prepare the update, we just need to back up our files
string ourFolder = Path.GetDirectoryName(typeof(GitHubUpdateManager).Assembly.Location) ?? "";
string backupFolder = Path.Combine(ourFolder, "..", "backup");
string backupFolder = Path.Combine(AppContext.BaseDirectory, "..", "backup");
await DeleteFolderRetry(backupFolder);

Directory.CreateDirectory(backupFolder);
FileSystem.CopyDirectory(ourFolder, backupFolder);
FileSystem.CopyDirectory(AppContext.BaseDirectory, backupFolder);
}
catch (Exception ex) {
Log.Error(ex);
Expand All @@ -72,16 +71,15 @@ public static async Task PrepareUpdate() {
public static void ExitApplicationToUpdate() {
try {
// Since we have a backup folder from PrepareUpdate() we can just run the backup executable
string ourFolder = Path.GetDirectoryName(typeof(GitHubUpdateManager).Assembly.Location) ?? "";
string backupFolder = Path.Combine(ourFolder, "..", "backup");
string backupFolder = Path.Combine(AppContext.BaseDirectory, "..", "backup");
if (!Directory.Exists(backupFolder)) {
return;
}

string ourExecutable = $"{AppDomain.CurrentDomain.FriendlyName}.exe";

// we must pass the installation folder to the executable so it knows where to install
Process.Start(Path.Combine(backupFolder, ourExecutable), $"--update \"{ourFolder}\"");
Process.Start(Path.Combine(backupFolder, ourExecutable), $"--update \"{AppContext.BaseDirectory}\"");
Environment.Exit(0);
}
catch (Exception ex) {
Expand All @@ -99,8 +97,7 @@ public static async Task PerformUpdateAndRestart(string owner, string repo, stri
await DeleteFolderContentsRetry(installFolder);

// Get the latest version of the application from GitHub.
string ourFolder = Path.GetDirectoryName(typeof(GitHubUpdateManager).Assembly.Location) ?? "";
string zipLocation = Path.Combine(ourFolder, assetName);
string zipLocation = Path.Combine(AppContext.BaseDirectory, assetName);
GithubLatestReleaseJson? latestVersion = await GetLatestVersion(owner, repo);
using (var client = new HttpClient()) {
using HttpResponseMessage response = await client.GetAsync($"https://github.com/{owner}/{repo}/releases/download/{latestVersion?.name}/{assetName}");
Expand All @@ -127,8 +124,7 @@ public static async Task PerformUpdateAndRestart(string owner, string repo, stri
/// Cleans up the previous update's files.
/// </summary>
public static async Task CleanupUpdate() {
string ourFolder = Path.GetDirectoryName(typeof(GitHubUpdateManager).Assembly.Location) ?? "";
string backupFolder = Path.Combine(ourFolder, "..", "backup");
string backupFolder = Path.Combine(AppContext.BaseDirectory, "..", "backup");

await DeleteFolderRetry(backupFolder);
}
Expand Down