Skip to content

chore: update log message and save magic number in constants file #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

chore: update log message and save magic number in constants file #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/Nullinside.Cicd.GitHub/Constants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,10 @@ public static class Constants {
/// The github project's unique identifier on github.
/// </summary>
public const int GITHUB_PROJECT_NUM = 1;

/// <summary>
/// The unique identifier on GitHub for the "done" status of items.
/// </summary>
/// <remarks>This was found by manually querying the API. It's a nightmare to pull. Hence the hardcoding.</remarks>
public const string GITHUB_PROJECT_DONE_SINGLE_SELECT_ID = "98236657";
}
4 changes: 2 additions & 2 deletions src/Nullinside.Cicd.GitHub/Rule/MoveClosedToDone.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ from projects in issueInfo.ProjectItems.Nodes
continue;
}

_log.Info($"{repo.Name}: Associating issue #{issue.IssueNumber}");
_log.Info($"{repo.Name}: Moving issue to done column (issue #{issue.IssueNumber})");

var mutation = new MutateIssueProjectStatuses(projectId.Value, issue.ProjectIssueId, issue.FieldId, "98236657");
var mutation = new MutateIssueProjectStatuses(projectId.Value, issue.ProjectIssueId, issue.FieldId, Constants.GITHUB_PROJECT_DONE_SINGLE_SELECT_ID);
await mutation.SendAsync();
}
}
Expand Down
Loading