Fix/karma #95
Merged
Fix/karma #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ng update didn't update angular.json file to point to the @Angular-devkit package for karma. I must have googled something to fix it in 77df8ef but only managed to install the package and not actually tell angular.json to use it. This change makes it so that we are building with a version of karma that allows run once (and matches what template you get using the ng new command) closes #84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug where Karma was not exiting in a single run and so it kept the "check" alive forever.
The ng update didn't update angular.json file to point to the
@angular-devkitpackage for karma. I must have googled something to fixit in 77df8ef but only managed to install the package and not actually
tell angular.json to use it. This change makes it so that we are
building with a version of karma that allows run once (and matches what
template you get using the ng new command)