Support systems where %LocalAppData% contains a space#85
Draft
canton7 wants to merge 1 commit intonullpo-head:mainfrom
Draft
Support systems where %LocalAppData% contains a space#85canton7 wants to merge 1 commit intonullpo-head:mainfrom
canton7 wants to merge 1 commit intonullpo-head:mainfrom
Conversation
Author
|
Marking as draft until I can test -- relying on your CI/CD, as I haven't quite figured how to build everything locally. I think tha requires your approval however... |
This can happen when the user's full name is used as %USERPROFILE%. Fixes: nullpo-head#72
canton7
force-pushed
the
72-appdata-with-space
branch
from
3358fb4 to
700090f
Compare
Author
|
Ah, this duplicates #82. Can we please look at merging one of these? It means that nobody within my company can use distrod, without some hackery |
|
Looks like this project died or something. Oh well. |
|
I closed my branch because yours is better |
|
@nullpo-head @Locietta Can this please be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can happen when the user's full name is used as %USERPROFILE%.
Fixes: #72