Skip to content

Conversation

@dougg0k
Copy link
Contributor

@dougg0k dougg0k commented Jul 16, 2025

Edit:

CI might need to be re-run after this PR is merged. #113


This is the changes requested in #89

https://github.com/margelo/react-native-quick-crypto

I didnt actually test anything because the setup of this project does not have a setup to easily do so. I suppose the CI can somewhat do so.

Feel free to test this PR first, before merge though.

@ngocle2497
Copy link
Collaborator

@dougg0k I don't think this PR is necessary, the encryption constructors only run once when building the application, there is no need to add a native library

@ngocle2497 ngocle2497 closed this Jul 27, 2025
@dougg0k
Copy link
Contributor Author

dougg0k commented Jul 27, 2025

And this was closed, why? @ngocle2497

@ngocle2497
Copy link
Collaborator

This PR adds 2 native libraries, currently nitro module requires new arch and this library supports both. Furthermore, is it worth adding 2 native libraries to solve the problem of generating randombytes in prebuild(not runtime)?

@ngocle2497
Copy link
Collaborator

and is it possible to call a function of a native library when there is no runtime? the flow of this library is as follows: start build -> create files -> build success -> app run(runtime available)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants