Skip to content

Conversation

@cosmic-chichu
Copy link
Contributor

update allowed python version

Signed-off-by: Shrivardhan Rao <shrivardhan92@gmail.com>
@cosmic-chichu cosmic-chichu self-assigned this Mar 27, 2025
@codecov
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.20%. Comparing base (157a90d) to head (9694254).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #221   +/-   ##
=======================================
  Coverage   94.20%   94.20%           
=======================================
  Files          55       55           
  Lines        2311     2311           
  Branches      119      119           
=======================================
  Hits         2177     2177           
  Misses         97       97           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pyproject.toml Outdated

[tool.poetry.dependencies]
python = ">=3.9, <3.13"
python = ">=3.9, <4.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it < 3.14.
Things might break otherwise in future

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Python changes a lot between the minor versions :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH, it is very difficult to support 5 versions of Python simultaneously and have trouble free builds. I would vote for dropping support for 3.9 if we are adding 3.13.
Anyway 3.9 is going obsolete after Oct 2025.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 yank support for 3.9

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it < 3.14.
Things might break otherwise in future

I'm against limiting the version of Python.
Please read the following: https://iscinumpy.dev/post/bound-version-constraints/
If you still think there's a good reason to block 3.14+, please share it.

Note that supported versions will still be listed in classifiers... so if somebody uses a version not listed, then they use at their own risk.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ambivalent about dropping support for Python 3.9, so I'll refrain from giving an opinion on that.

Signed-off-by: Shrivardhan Rao <shrivardhan92@gmail.com>
@cosmic-chichu cosmic-chichu requested a review from ab93 March 27, 2025 16:49
Copy link
Member

@ab93 ab93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure a minor version is released for this (when you release it).


[tool.poetry.dependencies]
python = ">=3.9, <3.13"
python = ">=3.9,<3.14"
Copy link
Member

@ab93 ab93 Mar 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "Programming Language :: Python :: 3.13"
in the classifiers

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to add tests to make sure python 3.13 pass
https://github.com/numaproj/numaflow-python/blob/main/.github/workflows/run-tests.yml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per my other comment, please consider changing to:

Suggested change
python = ">=3.9,<3.14"
python = "^3.9"

Or if none of this packages dependencies cap the Python version (unlikely), then this would be better:

Suggested change
python = ">=3.9,<3.14"
python = ">=3.9"

Signed-off-by: Shrivardhan Rao <shrivardhan92@gmail.com>
@kohlisid
Copy link
Contributor

@cosmic-chichu

  1. Lets test the CI build workflow
  2. proto compatibility
  3. UDF e2e execution

@vigith
Copy link
Member

vigith commented Mar 27, 2025

  1. proto compatibility

This is tricky, let's a CI rule for that in a follow up. I do not want to block this PR because of that.

Signed-off-by: Shrivardhan Rao <shrivardhan92@gmail.com>
Copy link
Contributor

@khneal khneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider removing the Python minor version cap, maybe in the next PR.

Is this PR still moving forward? I don't see any updates more than a month, and Python 3.13 went GA more than 6 months ago.

pyproject.toml Outdated

[tool.poetry.dependencies]
python = ">=3.9, <3.13"
python = ">=3.9, <4.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it < 3.14.
Things might break otherwise in future

I'm against limiting the version of Python.
Please read the following: https://iscinumpy.dev/post/bound-version-constraints/
If you still think there's a good reason to block 3.14+, please share it.

Note that supported versions will still be listed in classifiers... so if somebody uses a version not listed, then they use at their own risk.

pyproject.toml Outdated

[tool.poetry.dependencies]
python = ">=3.9, <3.13"
python = ">=3.9, <4.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ambivalent about dropping support for Python 3.9, so I'll refrain from giving an opinion on that.


[tool.poetry.dependencies]
python = ">=3.9, <3.13"
python = ">=3.9,<3.14"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per my other comment, please consider changing to:

Suggested change
python = ">=3.9,<3.14"
python = "^3.9"

Or if none of this packages dependencies cap the Python version (unlikely), then this would be better:

Suggested change
python = ">=3.9,<3.14"
python = ">=3.9"

@vigith
Copy link
Member

vigith commented Sep 29, 2025

this has been superseded by #245

@vigith vigith closed this Sep 29, 2025
@vigith vigith deleted the bumpPythonVersion branch September 29, 2025 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants