test: Tests for sink forwarder using simple buffer backed ISBs#3282
Open
vaibhavtiwari33 wants to merge 11 commits intomainfrom
Open
test: Tests for sink forwarder using simple buffer backed ISBs#3282vaibhavtiwari33 wants to merge 11 commits intomainfrom
vaibhavtiwari33 wants to merge 11 commits intomainfrom
Conversation
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3282 +/- ##
==========================================
+ Coverage 81.14% 81.23% +0.08%
==========================================
Files 316 316
Lines 72841 73147 +306
==========================================
+ Hits 59110 59422 +312
+ Misses 13172 13168 -4
+ Partials 559 557 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
…sink forwarder Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
vigith
reviewed
Mar 11, 2026
| let forwarder_cln = cln_token.clone(); | ||
| let forwarder_handle = tokio::spawn(async move { forwarder.start(forwarder_cln).await }); | ||
|
|
||
| tokio::time::sleep(Duration::from_millis(500)).await; |
vigith
reviewed
Mar 11, 2026
| .await; | ||
|
|
||
| // ISB Reader Orchestrator | ||
| let input_stream = Stream::new("sink-input-buffer", "test-in", 0); |
Member
There was a problem hiding this comment.
why is -buffer in there but not in https://github.com/numaproj/numaflow/pull/3282/changes#diff-6b6458796b57b7564d42246f83ddb31f9411fc3275a7e652ae7f06ba008276e2R437
Contributor
Author
There was a problem hiding this comment.
The name of the simple buffer adaptor could be different from the stream itself IMO.
…he test Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Tests for sink forwarder using simple buffer backed ISBs
Testing
This is the test