Skip to content

opex: emit SQS metrics#3315

Merged
yhl25 merged 8 commits intonumaproj:mainfrom
ayildirim21:sqs-metrics
Mar 17, 2026
Merged

opex: emit SQS metrics#3315
yhl25 merged 8 commits intonumaproj:mainfrom
ayildirim21:sqs-metrics

Conversation

@ayildirim21
Copy link
Member

@ayildirim21 ayildirim21 commented Mar 16, 2026

What this PR does / why we need it

Briefly describe the problem and the solution.

Related issues

Fixes #

Testing

How was this tested (unit/integration/manual)? Include commands, links, or screenshots if applicable.

Special notes for reviewers

Anything notable for review (risk, rollout, follow-ups).

Currently only adding producer side metrics as that is what is required for golden signals:

  • publish latency (histogram)
  • publish success (counter)
  • publish failure (counter

Abdullah Yildirim added 2 commits March 15, 2026 18:26
Signed-off-by: Abdullah Yildirim <abdullah_yildirim@intuit.com>
Signed-off-by: Abdullah Yildirim <abdullah_yildirim@intuit.com>
@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 91.02564% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.12%. Comparing base (ab8e64c) to head (978f62b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/numaflow-core/src/sinker/sink/sqs.rs 77.41% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3315      +/-   ##
==========================================
- Coverage   81.16%   81.12%   -0.04%     
==========================================
  Files         316      317       +1     
  Lines       72828    72907      +79     
==========================================
+ Hits        59108    59146      +38     
- Misses      13163    13207      +44     
+ Partials      557      554       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vigith vigith changed the title chore: emit SQS metrics opex: emit SQS metrics Mar 16, 2026
Abdullah Yildirim added 2 commits March 15, 2026 18:56
Signed-off-by: Abdullah Yildirim <abdullah_yildirim@intuit.com>
Signed-off-by: Abdullah Yildirim <abdullah_yildirim@intuit.com>
Copy link
Contributor

@yhl25 yhl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update metrics.md file?

Abdullah Yildirim added 2 commits March 15, 2026 21:13
Signed-off-by: Abdullah Yildirim <abdullah_yildirim@intuit.com>
Signed-off-by: Abdullah Yildirim <abdullah_yildirim@intuit.com>
Abdullah Yildirim added 2 commits March 16, 2026 13:22
Signed-off-by: Abdullah Yildirim <abdullah_yildirim@intuit.com>
Signed-off-by: Abdullah Yildirim <abdullah_yildirim@intuit.com>
@ayildirim21 ayildirim21 requested review from vigith and yhl25 March 16, 2026 21:01
@yhl25 yhl25 merged commit 38b0ff8 into numaproj:main Mar 17, 2026
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants