chore: Eliminate unnecessary reconciliations after progressive rollout failure#976
Open
chore: Eliminate unnecessary reconciliations after progressive rollout failure#976
Conversation
Signed-off-by: jvogelman <julie_vogelman@intuit.com> Branch-Creation-Time: 2026-03-16T21:52:40+0000
Signed-off-by: jvogelman <julie_vogelman@intuit.com>
Signed-off-by: jvogelman <julie_vogelman@intuit.com>
Signed-off-by: jvogelman <julie_vogelman@intuit.com>
Signed-off-by: jvogelman <julie_vogelman@intuit.com>
juliev0
commented
Mar 17, 2026
|
|
||
| // if we still have interstepbufferservices that need deleting, or if we're in the middle of an upgrade strategy, then requeue | ||
| if !allDeleted || inProgressStrategy != apiv1.UpgradeStrategyNoOp { | ||
| if !allDeleted || inProgressStrategy == apiv1.UpgradeStrategyPPND { |
Collaborator
Author
There was a problem hiding this comment.
in the case of Progressive, we have other logic which is causing us to requeue if we're in the middle of the assessment - we don't need this
juliev0
commented
Mar 17, 2026
| requeueDelay = progressiveRequeueDelay | ||
| } | ||
| if assessmentComplete { | ||
| if !failed { |
Collaborator
Author
There was a problem hiding this comment.
Github is making it seem like the code in this block failed, but it hasn't. Only the if done got changed to:
if assessmentComplete {
if !failed {
juliev0
commented
Mar 17, 2026
| } | ||
|
|
||
| // requeue using the provided delay | ||
| return progressiveRequeueDelay, nil |
Collaborator
Author
There was a problem hiding this comment.
requeue if we're mid-assessment
juliev0
commented
Mar 17, 2026
| requeueDelay = common.DefaultRequeueDelay | ||
|
|
||
| } else { | ||
| requeueDelay = progressiveRequeueDelay |
Collaborator
Author
There was a problem hiding this comment.
this requeueing is taken care of at the top where we now do this:
if progressiveRequeueDelay > 0 {
requeueDelay = progressiveRequeueDelay
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #773
Modifications
After we assess a progressive rollout failure, we don't need to be requeing every 20 seconds like we have been. This wastes cpu cycles.
Once there is an update to the rollout spec, we will reconcile again. There's nothing to do in the meantime.
Verification
I performed the following tests with both pipelinerollout, isbservicerollout, and monovertexrollout:
Backward (and forward) incompatibilities
N/A