Skip to content

Conversation

@sklam
Copy link
Member

@sklam sklam commented Sep 29, 2025

  • making pytest ./llm_midend.py all passes
  • strip trailing whitespaces

@sklam sklam requested a review from kc611 September 29, 2025 22:33
@kc611
Copy link
Contributor

kc611 commented Oct 2, 2025

The following patch fixes the current test failures:

diff --git a/sealir-tutorials/llm_midend.py b/sealir-tutorials/llm_midend.py
index ef9c8a5..d45b3c3 100644
--- a/sealir-tutorials/llm_midend.py
+++ b/sealir-tutorials/llm_midend.py
@@ -3003,7 +3003,7 @@ class MlirBackend(_ch06_MlirBackend):
                     ir.AffineMap.get_identity(nd),
                     ir.AffineMap.get_identity(nd)
                 ],
-                iterator_types=ir.ArrayAttr.get([ir.Attribute.parse("#linalg.iterator_type<parallel>")]*2)
+                iterator_types=ir.ArrayAttr.get([ir.Attribute.parse("#linalg.iterator_type<parallel>")]*nd)
             )
 
             body = generic_op.regions[0].blocks.append(
@@ -3039,7 +3039,7 @@ class MlirBackend(_ch06_MlirBackend):
                 ir.AffineMap.get_identity(nd),
                 ir.AffineMap.get_identity(nd)
             ],
-            iterator_types=ir.ArrayAttr.get([ir.Attribute.parse("#linalg.iterator_type<parallel>")])
+            iterator_types=ir.ArrayAttr.get([ir.Attribute.parse("#linalg.iterator_type<parallel>")]*nd)
         )
 
         body = generic_op.regions[0].blocks.append(

@sklam
Copy link
Member Author

sklam commented Oct 3, 2025

By 50c82ff,
I'm starting to test tensor dialect in an attempt to get optimal code.

@sklam sklam changed the title [llm integrate] fixing tests [llm integrate] wip faster codegen and various improvements Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants