Refactoring jump targets and backedges to update inplace#83
Open
kc611 wants to merge 7 commits intonumba:mainfrom
Open
Refactoring jump targets and backedges to update inplace#83kc611 wants to merge 7 commits intonumba:mainfrom
kc611 wants to merge 7 commits intonumba:mainfrom
Conversation
Member
|
Can this be rebased onto |
kc611
force-pushed
the
outedges_refactor
branch
from
f04eeb9 to
adeeacf
Compare
kc611
force-pushed
the
outedges_refactor
branch
from
adeeacf to
d2331e7
Compare
Member
|
Question: why was it necessary to remove the ability to deep-copy before application of any major algorithm? It should still be possible to deep-copy between closing, loop- and branch-restructure? |
esc
requested changes
Aug 3, 2023
Member
esc
left a comment
esc
left a comment
There was a problem hiding this comment.
I have given this a first pass and found some items to address.
Contributor
Author
It wasn't necessary to remove it, but rather it makes no difference for it to be there, since the graph is anyways mutable. Unless we have a fallback mechanism which I think is actually something we should look into. |
Co-authored-by: esc <esc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #73
Builds on top of #50
As an alternative to #58,
We can update the
jump_targetsandbackedgeswithin theBasicBlockobject to prevent copies and do minimal changes to code logic.