Update text cost extraction to use new graph extractor#15
Draft
saulshanabrook wants to merge 1 commit intonumba:mainfrom
Draft
Update text cost extraction to use new graph extractor#15saulshanabrook wants to merge 1 commit intonumba:mainfrom
saulshanabrook wants to merge 1 commit intonumba:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to try using the new graph based extractor and custom cost model added to egglog in egraphs-good/egglog-python#357. It was developed in tandem with that PR to help drive the interface.
I only updated the specific extraction tests, but didn't start looking at how to update the actual extraction interface within the larger system yet, or run any larger tests.
The extraction algorithm also may not be the same, it should be equivalent to https://github.com/egraphs-good/extraction-gym/blob/main/src/extract/greedy_dag.rs