Affichage des erreurs de champs#235
Merged
Ash-Crow merged 2 commits intonumerique-gouv:mainfrom Jun 3, 2025
Merged
Conversation
Collaborator
|
Bonjour et merci pour cette PR, j'en ai fait une très similaire (#234 ) mais je fais la vérification à un autre endroit... Je vais merger ta modif et revoir la mienne (qui a les tests unitaires) |
Ash-Crow
reviewed
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Objectif
L'issue décrit le problème: #232
L'objectif est d'avoir dans la vue debug de la template l'origine exacte de l'erreur quand avec le tag
dsfr_form_fieldon ne met pas le bon champs.🔍 Implémentation
Un test au niveau du tag
dsfr_form_fieldpour éviter que les typos dans les noms de champs fassent des erreurs très difficiles à remonterOn pourrait même tester le type de variable pour s'assurer que c'est bien un champs de formulaire.
Je n'ai pas encore écrit les tests.
🖼️ Images
Maintenant on sait ou regarder si le champs n'est pas bien nommé au niveau de la template
