fixed permissions

[AR21SM]

Description of Changes

Related Issue

fix #80

Type of Change

Please check the appropriate box that describes your PR:

• 🐛 Bug Fix — Fixes a documented issue or incorrect behavior
• ✨ Content Enhancement — Updates or improves existing content
• ✍️ New Content — Adds new chapters, examples, or significant sections
• 🛠️ Other — Please describe in the Description of Changes section

Additional Notes (Optional)

Checklist

• I have searched open pull requests to avoid duplicates.
• I have built the book locally using the build instructions and verified my changes work as expected.
• I have written clear, conventional commit messages, as per the Pull Request Guidelines.

[AR21SM]

Hi @aterrel , We need to set up the following,
https://github.com/rossjrw/pr-preview-action?tab=readme-ov-file#:~:text=The%20default%20value%20works%20for%20non%2Dfork%20pull%20requests%20to%20the%20same%20repository

Quick Summary for setting this up :

1. Go to: https://github.com/settings/tokens
2. Click Generate new token (classic)
   
3. Set the following scopes: repo + workflows
   
4. Click Generate token and copy it
5. Go to the repository settings
6. Under Secrets and variables -> Actions -> Repository secrets, click New repository secret.
   

• Name: PREVIEW_TOKEN
• Value: Paste the token you copied

After this, I believe this will work correctly, as this exact setup is already working in my forked repository.

[aterrel]

okay will try

…

On Sat, Jun 28, 2025 at 6:58 AM Ashish Mahajan ***@***.***> wrote: *AR21SM* left a comment (numfocus/DISCOVER-Cookbook#343) <#343 (comment)> Hi @aterrel <https://github.com/aterrel> , We need to set up the following, https://github.com/rossjrw/pr-preview-action?tab=readme-ov-file#:~:text=The%20default%20value%20works%20for%20non%2Dfork%20pull%20requests%20to%20the%20same%20repository Quick Summary for setting this up : 1. Go to: https://github.com/settings/tokens 2. Click Generate new token (classic) image.png (view on web) <https://github.com/user-attachments/assets/03ae62e9-7f12-4b96-b6ee-7b0bc89b1399> 3. Set the following scopes: repo + workflows image.png (view on web) <https://github.com/user-attachments/assets/151857ed-7cec-4384-aa48-d70548e659f4> 4. Click Generate token and copy it 5. Go to the repository settings 6. Under Secrets and variables -> Actions -> Repository secrets, click New repository secret. image.png (view on web) <https://github.com/user-attachments/assets/af793520-3c3d-4fa8-8dfc-87518a74e4d7> - Name: PREVIEW_TOKEN - Value: Paste the token you copied After this, I believe this will work correctly, as this exact setup is already working in my forked repository. image.png (view on web) <https://github.com/user-attachments/assets/c32d9531-ad15-43fd-8f00-9d29435a7155> — Reply to this email directly, view it on GitHub <#343 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAHO5ZHIIBMW7C3VIO425T3FZ7N5AVCNFSM6AAAAACAKPPBQCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMJVGIYDOOJSGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[AR21SM]

okay will try

Hi @aterrel, thanks for looking into it!
this unfortunately won’t work with forked pull requests currently :(
https://github.com/rossjrw/pr-preview-action#:~:text=This%20Action%20does%20not%20currently%20support%20deploying%20previews%20for%20PRs%20from%20forks%2C%20but%20will%20do%20so%20in%20the%20upcoming%20v2.

I’ll open a discussion comparing Netlify and CircleCI as alternatives, with their pros and cons, so we can decide the best path forward.

[aterrel]

okay will try

Hi @aterrel, thanks for looking into it! this unfortunately won’t work with forked pull requests currently :( https://github.com/rossjrw/pr-preview-action#:~:text=This%20Action%20does%20not%20currently%20support%20deploying%20previews%20for%20PRs%20from%20forks%2C%20but%20will%20do%20so%20in%20the%20upcoming%20v2.

I’ll open a discussion comparing Netlify and CircleCI as alternatives, with their pros and cons, so we can decide the best path forward.

Yeah that's not good. I don't want to give access to folks who are putting in changes for the first time.

[aterrel]

closing as discussed in #345 we will try Netlify

[AR21SM]

Hi @aterrel
Just for context, the last commit included this condition:
if: ${{ github.event.pull_request.head.repo.full_name == github.event.pull_request.base.repo.full_name }}

This ensures that the action only runs for non-forked PRs, avoiding the red ❌ cross on forked ones.

Once v2 is officially released and the behavior is updated in the README, we can either:

• remove this if condition entirely, or
• create an issue to update it according to their documentation.

Alternatively, we could comment out :

pull_request: types: - opened - reopened - synchronize - closed
...so it doesn't run at all on PRs