fix: robust SSE parsing for multiline JSON and fallback handling#96
Open
harshav167 wants to merge 1 commit intonumman-ali:mainfrom
Open
fix: robust SSE parsing for multiline JSON and fallback handling#96harshav167 wants to merge 1 commit intonumman-ali:mainfrom
harshav167 wants to merge 1 commit intonumman-ali:mainfrom
Conversation
- Handle data: with or without space after colon - Support multiline JSON split across multiple data: lines - Graceful fallback chain: finalResponse → lastResponseLike → lastEvent - Skip malformed JSON lines while preserving valid subsequent events - Add tests for edge cases (no-space colon, multiline data)
Owner
|
Thanks! I haven’t been able to reproduce yet. If you can share a failing raw SSE payload or |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes SSE parsing issues when Codex API returns non-standard SSE formats.
Changes
data:with or without space after colon (bothdata: {...}anddata:{...})data:linesfinalResponse→lastResponseLike→lastEventFiles Changed
lib/request/response-handler.ts- Enhanced SSE parsing logictest/response-handler.test.ts- Added edge case tests