Removed all instances of assert_almost_equal #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Kai-Striega! |
|
Hello @ArCh12312 firstly my apologies for taking so long to reply, I was on holiday over Christmas/New Year's and didn't check my GitHub. I'm back and should be quicker to respond from now on. I'll review this over the weekend. Thanks for being patient. |
|
Hey, @Kai-Striega! Wish you a very happy new year! Thank you for the note. |
Kai-Striega
approved these changes
Jan 7, 2024
Comment on lines
+20
to
+22
| if hasattr(actual, "__iter__") and hasattr(expected, "__iter__"): | ||
| for a, e in zip(actual, expected): | ||
| assert abs(a - e) <= tol |
There was a problem hiding this comment.
This is an elegant solution!
|
Thank you for the approval! I will make sure to use Ruff only the necessary bits from next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#66 Fixed the issue.
Changed assert_almost_equals to assert_allclose and a custom function(assert_decimal_close).
Had to create assert_decimal_close, which finds the absolute difference in values and compares it to a tolerance level.
Cannot use the assert_allclose because it uses infinite under the covers which does not support the Decimal type.
See issue: numpy/numpy#9954
In addition, ran ruff format test_financial.py