Skip to content

Fixing bad union corruption #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2025
Merged

Fixing bad union corruption #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dff30c0
avoid direct union casting, bad
SwayamInSync Sep 11, 2025
bcc67e6
bumping version to 0.2
SwayamInSync Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions quaddtype/numpy_quaddtype/src/umath/comparison_ops.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,15 +121,19 @@ quad_generic_comp_strided_loop_aligned(PyArrayMethod_Context *context, char *con
QuadPrecDTypeObject *descr = (QuadPrecDTypeObject *)context->descriptors[0];
QuadBackendType backend = descr->backend;
while (N--) {
quad_value in1 = *(quad_value *)in1_ptr;
quad_value in2 = *(quad_value *)in2_ptr;
quad_value in1;
quad_value in2;

npy_bool result;

if (backend == BACKEND_SLEEF) {
in1.sleef_value = *(Sleef_quad *)in1_ptr;
in2.sleef_value = *(Sleef_quad *)in2_ptr;
result = sleef_comp(&in1.sleef_value, &in2.sleef_value);
}
else {
in1.longdouble_value = *(long double *)in1_ptr;
in2.longdouble_value = *(long double *)in2_ptr;
result = ld_comp(&in1.longdouble_value, &in2.longdouble_value);
}

Expand Down
2 changes: 1 addition & 1 deletion quaddtype/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ build-backend = "mesonpy"
[project]
name = "numpy_quaddtype"
description = "Quad (128-bit) float dtype for numpy"
version = "0.1.0"
version = "0.2.0"
readme = 'README.md'
license = { file = "LICENSE" }
authors = [{name = "Swayam Singh", email = "[email protected]"}]
Expand Down
Loading