-
-
Notifications
You must be signed in to change notification settings - Fork 15
Add basic documentation site #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Would it be possible to add an updated version of the release tracker table to the docs? This would be a great place to list all supported ufuncs and where we could later document e.g. the ULPs for each function |
|
Thanks @melissawm @juntyr yeah we will extend this, to add all those details |
| ] | ||
|
|
||
| docs = [ | ||
| "sphinx", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ngoldbaum (didn't explored in deep yet) Would this startup setup be extendable to your work (https://unyt.readthedocs.io/en/stable/)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, unyt also uses sphinx. It doesn't use myst because unyt predates myst.
I would defer to Melissa's setup. Maybe look at unyt if you're interested in setting up doctesting.
|
@SwayamInSync Should we just merge this in for 1.0? |
|
I was having some plans for this actually, |
|
You can but I wouldn't recommend it. It's much better IMO for doc changes to happen at the same time as code changes. My recommendation is to merge this, set up a docs site on github pages or readthedocs, and iterate from there. |
Sure then, I'll resolve its conflict and merge in after #246 |
|
Let me know if I can help! |
|
Hi @melissawm yeah so should I merge this and then you can guide me on setting up the site? |
|
RTD is a fine option, but we could also go with a simple github pages site. Happy to submit a workflow here for that. Wdyt? To help with the decision here are the options:
Both yaml files are very simple and I can set up either. |
|
The github one sounds more direct, we can go with that then. |
|
Readthedocs has the advantage of preserving all versions of the docs so that you can look back |
|
The pydata-sphinx-theme also has a built in version switcher, it's just not activated yet but I can do that. In that case, both options would have a version switcher. It's your call really, I'd recommend github pages just because all the config and deployment is centralized in github and all repo admins will be able to manage that. For RTD, that's a separate login, separate list of admins etc |
|
I think we can go with gh-pages for now, at this point content matters more and having everything right here will be easier to iterate |
|
Let me push the config then! I'll enable pages for the repo too. Will ping you once it's ready |
6278402 to
388e65e
Compare
|
@SwayamInSync this is now ready to merge. The GH action to build and deploy pages will not work unless it's merged to main, but I'm pretty confident it will work (tested locally). Cheers! |
SwayamInSync
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @melissawm , this look good to me,
Just a small question here, I am also okay with the current address
quaddtype/README.md
Outdated
| The documentation is automatically built and served using GitHub Pages. Every time changes are pushed to the `main` branch, the documentation is rebuilt and deployed to the `gh-pages` branch of the repository. You can access the documentation at: | ||
| ``` | ||
| https://numpy.github.io/numpy-user-dtypes/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a curious question, is it possible to route it to numpy.github.io/numpy-user-dtypes/quaddtype ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, we can add a redirect. Let me test and see what's the best approach here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
|
Another thing that may be worth considering: has quaddtype outgrown this repo? Maybe it deserves to have its own repo in the NumPy org on GitHub. |
I feel this true, the current codebase ~15K Lines (If also consider We do again have to setup the PyPI env |
|
A downside is it would lose the old PR numbers, although they’ll live on in this repo. We’ll have to make sure to export the history in a way that preserves all the commits - it’s not great for git history to start with a huge codebase. |
git-history can be cloned, but the individual PRs might be harder to port. Here all PRs have the label |
|
At least issues can be transferred to a new repo? |
|
If the plan is to move repos, do you still want the redirect? |
|
This should work :) Locally it does: https://melissawm.github.io/numpy-user-dtypes/quaddtype/ |
|
Ah I will later also remove the docs folder from testing CI's path, as these tests aren't required here |
|
Thanks again @melissawm this is good, I am going ahead to merge this. |
|
Oh yeah, I forgot : we actually get the nice numpy.org domain 😁 |
@SwayamInSync so sorry it took me so long!!
Here's a basic docs site setup. I haven't set up the website yet, but I can give you instructions later. Here's a preview of how the site looks like right now: https://melissawm.github.io/numpy-user-dtypes/