Skip to content

Fix build instructions #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2025
Merged

Fix build instructions #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2bb4c2
Fix build instructions
ngoldbaum Nov 20, 2025
d2cbdb4
clarify build warnings
ngoldbaum Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions quaddtype/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,11 @@ Building the `numpy-quaddtype` package:
python3 -m venv temp
source temp/bin/activate

# Install the package
pip install numpy pytest
# Install NumPy from source
pip install "numpy @ git+https://github.com/numpy/numpy.git"

# Install build and test dependencies
pip install pytest meson meson-python

# To build without QBLAS (default for MSVC)
# export CFLAGS="-DDISABLE_QUADBLAS"
Expand Down
10 changes: 5 additions & 5 deletions quaddtype/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,23 +50,23 @@ if sleef_dep.found() and sleef_dep.type_name() != 'internal'
)
use_system_sleef = true
else
fallback_reason = 'quad-precision support is not working'
fallback_reason = 'System-wide SLEEF installation found but a test for quad precision support failed.'
endif
else
fallback_reason = 'sleefquad library is missing'
fallback_reason = 'System-wide SLEEF installation does not have a sleefquad library.'
endif
else
fallback_reason = 'SLEEF not found system-wide'
fallback_reason = 'Cannot find system-wide SLEEF installation.'
endif

if use_system_sleef
message('Using system-wide SLEEF installation with quad-precision support')
else
warning('Falling back to SLEEF subproject: ' + fallback_reason)
sleef_subproj = subproject('sleef')
sleef_dep = sleef_subproj.get_variable('sleef_dep')
sleefquad_dep = sleef_subproj.get_variable('sleefquad_dep')
message('Using SLEEF subproject')
warning(fallback_reason)
message('Proceeding with vendored SLEEF subproject instead')
endif

incdir_numpy = run_command(py,
Expand Down