-
-
Notifications
You must be signed in to change notification settings - Fork 15
Restructuring quaddtype to use src layout
#253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Following is the new quaddtype directory structure |
juntyr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Sorry for the delay - I try not to spend too much time looking at code on weekends. You should be on the lookout for any breakage that happens as a result of this. Maybe also turn the docs build on for pull requests? I just checked and I don't think this break the docs build but it could have. |
As of now I didn't find any, meson nicely exposed the subproject's includes so they also don't need any change and workflows are also green.
Right the current docs should be fine as it is very bare-minimum (all relying on |
|
@SwayamInSync This still looks good to me, I'd be happy with you merging it |
|
Waiting for the #246 get resolved first as this restructuring might cause confusion there :) |
closes #252
As per the comment #252 (comment)