Disable code execution on page load for the NumPy REPL#824
Merged
stefanv merged 2 commits intonumpy:mainfrom Jan 28, 2025
Merged
Disable code execution on page load for the NumPy REPL#824stefanv merged 2 commits intonumpy:mainfrom
stefanv merged 2 commits intonumpy:mainfrom
Conversation
✅ Deploy Preview for numpy-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
The failures from the link checker are unrelated. Here are two screenshots of the REPL for a comparison: Before
After
It would be possible to customise the position of the code prompt cell (top/bottom/etc.) when jupyterlab/jupyterlab#13837 makes it to a release and when JupyterLite updates to that version of JupyterLab (hopefully soon!). |
agriyakhetarpal
changed the title
stefanv
approved these changes
Jan 21, 2025
Contributor
stefanv
left a comment
stefanv
left a comment
There was a problem hiding this comment.
Thanks @agriyakhetarpal; that's a good way to save some resources.
Contributor
|
See #825 for a CI fix. |
Contributor
|
Thank you @agriyakhetarpal! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of what is fixed or changed
This pull request disables the code execution for the
import numpy as npcommand, which should reduce bandwidth usage as NumPy would then not be downloaded from the Pyodide CDN as a result until the user decides to press the Enteror return buttons (or any other buttons to inject code into the REPL).This useful option comes from jupyterlite/jupyterlite#1547, which was released in https://github.com/jupyterlite/jupyterlite/releases/tag/v0.5.0, and was updated to in jupyterlite/demo#150, i.e., with the JupyterLite deployment that we use.
cc: @rgommers