Make version available to Python without dependencies; and to Sphinx metadata #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've checked that |
jschueller
approved these changes
Oct 25, 2017
pv
reviewed
Nov 1, 2017
| import os | ||
|
|
||
| from distutils.command.sdist import sdist | ||
| import setuptools |
There was a problem hiding this comment.
IIRC, the import monkeypatches distutils and changes behavior.
Is it ok to remove? Maybe best to leave as is, if not sure.
|
I'm not sure about the monkeypatching. I'll put it back in as no doubt it
has some effect on a version we don't test!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51. See also #94.