Switch to dependency groups #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanv
approved these changes
May 28, 2025
Contributor
stefanv
left a comment
stefanv
left a comment
There was a problem hiding this comment.
This is great, thanks! If no one else comments in the next day or two, feel free to self-merge.
| - name: Install | ||
| run: | | ||
| python -m pip install .[test,doc] | ||
| python -m pip install . --group test --group doc |
Contributor
There was a problem hiding this comment.
May be worth separating this in two steps, to show that one deals with installing dependencies, the other with the library. No big deal, though.
Collaborator
|
Thanks @stefmolin ! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #625
PEP 735 added dependency groups to
pyproject.toml, which would remove the need to have multiple requirements files. This PR makes that switchover and removes the script that generated those files along with the local pre-commit hook to trigger it.I also renamed the "developer" group as "dev", which with
uvat least gets installed automatically by default when building from source. I also included the "doc" and "test" groups inside the "dev" group, so developers have everything bundled.NOTE: I'm not sure how to test the changes to the
.readthedocs.yamlfile.