Remove spaces resulting from line continuation in arg type descriptor #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lagru
reviewed
Jan 21, 2026
| # bound: length of the parameter, plus three (for | ||
| # space-colon-space). | ||
| arg_type = re.sub(rf" {{{N + 3},}}", " ", arg_type_w_whitespace) | ||
| else: |
There was a problem hiding this comment.
I may not be following entirely but this seems wrong to me? Can it deal with the formatting below, where arg_name is quite long?
"""
Parameters
----------
very_long_arg_name : type wrapped \
over multiple lines
Description goes here.
"""
Why not just use
re.sub(r"\s{2,}", " ", arg_type_w_whitespace)\s should also be able to deal with non-breaking spaces and such.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-87