Skip to content

👽️ ndarray (pending) deprecations for strides and shape #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jorenham merged 3 commits into from
Dec 24, 2025
Merged

👽️ ndarray (pending) deprecations for strides and shape #773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd60209
👽️ `ndarray.strides.fset` pending deprecation
jorenham Dec 24, 2025
20fe490
👽️ `ndarray.shape.fset` pending deprecation
jorenham Dec 24, 2025
c52e0d7
✅ update rejection test for the `ndarray.shape` setter
jorenham Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/numpy-stubs/@test/static/reject/ma.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import numpy as np

m: np.ma.MaskedArray[tuple[int], np.dtype[np.float64]]

m.shape = (3, 1) # type: ignore[arg-type, assignment]
m.shape = (3, 1) # type: ignore[arg-type, assignment] # pyright: ignore[reportDeprecated]
m.dtype = np.bool # type: ignore[assignment, misc] # pyright: ignore[reportAttributeAccessIssue]

np.amin(m, axis=1.0) # type: ignore[call-overload] # pyright: ignore[reportArgumentType, reportCallIssue]
Expand Down
4 changes: 3 additions & 1 deletion src/numpy-stubs/__init__.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ from typing import (
overload,
type_check_only,
)
from typing_extensions import Buffer, CapsuleType, Protocol, TypeVar, override
from typing_extensions import Buffer, CapsuleType, Protocol, TypeVar, deprecated, override

import _numtype as _nt

Expand Down Expand Up @@ -1718,12 +1718,14 @@ class ndarray(_ArrayOrScalarCommon, Generic[_ShapeT_co, _DTypeT_co]):
# def shape(self: _nt.HasInnerShape[_ShapeT] | ndarray[_ShapeT2]) -> _ShapeT | _ShapeT2: ... # noqa: ERA001
def shape(self: ndarray[_AnyShapeT]) -> _AnyShapeT: ...
@shape.setter
@deprecated("In-place shape modification will be deprecated in NumPy 2.5.", category=PendingDeprecationWarning)
def shape(self: _nt.HasInnerShape[_ShapeT] | ndarray[_ShapeT2], shape: _ShapeT | _ShapeT2, /) -> None: ...

#
@property
def strides(self) -> tuple[int, ...]: ...
@strides.setter
@deprecated("Setting the strides on a NumPy array has been deprecated in NumPy 2.4")
def strides(self, value: tuple[int, ...], /) -> None: ...

#
Expand Down