Conversation
…tions Co-authored-by: r-devulap <44766858+r-devulap@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor xss_argselect and xss_argsort to use const T* parameter
Propagate Feb 23, 2026
const T* through argsort/argselect call chain, remove std::remove_const_t workarounds
Member
|
@AnkitAhlawat7742 I put an agent to task to resolve #229 (comment). Lets see how it does :) |
Member
|
@copilot fix the lint CI failures |
Co-authored-by: r-devulap <44766858+r-devulap@users.noreply.github.com>
Contributor
Author
Member
|
@seberg mind approving this PR? My approval is apparently not enough :) |
r-devulap
approved these changes
Feb 24, 2026
Member
|
Hummm, I guess because you triggered that agent maybe? Which honestly makes some sense. If this becomes annoying, we can consider removing the "one approval required" rule maybe (I suppose that is active somewhere). |
seberg
previously approved these changes
Feb 24, 2026
seberg
reviewed
Feb 24, 2026
Member
Might be useful going forward. |
seberg
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
const T*toxss_argsort,xss_argselectand all related internal functionsstd::remove_const_tandconst_castworkarounds from wrapper functionsstd_argselect_withnan,std_argsort_withnan, and function call sites)🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.