Skip to content

Propagate const T* through argsort/argselect call chain, remove std::remove_const_t workarounds#231

Merged
r-devulap merged 4 commits intomainfrom
copilot/remove-remove-const-t
Feb 24, 2026
Merged

Propagate const T* through argsort/argselect call chain, remove std::remove_const_t workarounds#231
r-devulap merged 4 commits intomainfrom
copilot/remove-remove-const-t

Conversation

Copy link
Contributor

Copilot AI commented Feb 23, 2026

  • Propagate const T* to xss_argsort, xss_argselect and all related internal functions
  • Remove std::remove_const_t and const_cast workarounds from wrapper functions
  • Fix clang-format violations (parameter list line-wrapping in std_argselect_withnan, std_argsort_withnan, and function call sites)

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

…tions

Co-authored-by: r-devulap <44766858+r-devulap@users.noreply.github.com>
Copilot AI changed the title [WIP] Refactor xss_argselect and xss_argsort to use const T* parameter Propagate const T* through argsort/argselect call chain, remove std::remove_const_t workarounds Feb 23, 2026
Copilot AI requested a review from r-devulap February 23, 2026 15:39
@r-devulap
Copy link
Member

r-devulap commented Feb 23, 2026

@AnkitAhlawat7742 I put an agent to task to resolve #229 (comment). Lets see how it does :)

@r-devulap r-devulap marked this pull request as ready for review February 24, 2026 04:01
@r-devulap
Copy link
Member

@copilot fix the lint CI failures

Co-authored-by: r-devulap <44766858+r-devulap@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 24, 2026

@copilot fix the lint CI failures

Fixed in 37ec892. The failures were clang-format violations in parameter list formatting for std_argselect_withnan, std_argsort_withnan, and two function call sites in the wrapper functions. Applied clang-format -style=file -i to reformat them correctly.

Copy link
Member

@r-devulap r-devulap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@r-devulap
Copy link
Member

@seberg mind approving this PR? My approval is apparently not enough :)

@seberg
Copy link
Member

seberg commented Feb 24, 2026

Hummm, I guess because you triggered that agent maybe? Which honestly makes some sense.

If this becomes annoying, we can consider removing the "one approval required" rule maybe (I suppose that is active somewhere).

seberg
seberg previously approved these changes Feb 24, 2026
@r-devulap
Copy link
Member

If this becomes annoying, we can consider removing the "one approval required" rule maybe (I suppose that is active somewhere).

Might be useful going forward.

@r-devulap r-devulap merged commit e6edb07 into main Feb 24, 2026
12 of 13 checks passed
@seberg seberg deleted the copilot/remove-remove-const-t branch February 24, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants