Merge pull request #116 from numtide/add-rbac-for-extra-pb-requirements

Add RBAC marker and access mode handling for backup

Author: rytswd

api/v1alpha1/common_types.go

@@ -69,6 +69,11 @@ type StorageSpec struct {
 	// +kubebuilder:validation:MinLength=1
 	// +kubebuilder:validation:MaxLength=63
 	Class string `json:"class,omitempty"`
+
+	// AccessModes contains the desired access modes the volume should have.
+	// More info: https://kubernetes.io/docs/concepts/storage/persistent-volumes#access-modes
+	// +optional
+	AccessModes []corev1.PersistentVolumeAccessMode `json:"accessModes,omitempty"`
 }
 
 // ContainerConfig defines generic container configuration.

api/v1alpha1/shard_types.go

@@ -36,6 +36,7 @@ import (
 // +kubebuilder:rbac:groups=apps,resources=deployments;statefulsets,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups="",resources=services,verbs=get;list;watch;create;update;patch;delete
 // +kubebuilder:rbac:groups="",resources=persistentvolumeclaims,verbs=get;list;watch;create;update;patch;delete
+// +kubebuilder:rbac:groups="",resources=configmaps,verbs=get;list;watch;create;update;patch;delete
 
 // ============================================================================
 // Shard Component Specs (Reusable)
@@ -77,13 +78,10 @@ type PoolSpec struct {
 	// +optional
 	Storage StorageSpec `json:"storage,omitempty"`
 
-	// BackupStorageType defines how backup storage is provided.
-	// Valid values are "hostPath" (for single-node testing) and "pvc" (for production).
-	// Defaults to "hostPath".
+	// BackupStorage defines the storage configuration for backup volumes.
+	// Shared across all pods in a pool. Defaults to same as Storage if not specified.
 	// +optional
-	// +kubebuilder:validation:Enum=hostPath;pvc
-	// +kubebuilder:default="hostPath"
-	BackupStorageType string `json:"backupStorageType,omitempty"`
+	BackupStorage StorageSpec `json:"backupStorage,omitempty"`
 
 	// Postgres container configuration.
 	// +optional