fix(gc): replace manual finalizers with native k8s cascading deletion#125
Merged
fernando-villalba merged 1 commit intomainfrom Jan 19, 2026
Merged
Conversation
The previous implementation relied on custom finalizers for garbage collection, which created complex dependency chains and often blocked resource deletion if the operator was down. - Removed manual finalizer logic from MultigresCluster and TableGroup controllers. - Updated ChildResourceValidator to exempt the generic-garbage-collector service account. - Removed obsolete integration tests checking for finalizer presence. - Added comprehensive failure case tests for sub-reconcilers and status updates. This reduces operator complexity, prevents "stuck" deleting resources, and achieves 100% test coverage for the cluster handler.
🔬 Go Test Coverage ReportSummary
Status✅ PASS DetailShow New Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation relied on custom finalizers for garbage collection, which created complex dependency chains.
This reduces operator complexity, prevents "stuck" deleting resources, and achieves 100% test coverage for the cluster handler.