feat(api): Ensuring all pods start successfully with default configurations#127
Merged
fernando-villalba merged 2 commits intomainfrom Jan 20, 2026
Merged
Conversation
…ations. Introduces `RootPath` configuration for Etcd specs, updates default container images, and refines CRD definitions. Addresses resulting regressions in tests and adds comprehensive coverage for new paths. - **API/CRD**: - Added `rootPath` field to EtcdSpec (default: `/multigres/global`) in `v1alpha1` and CRDs. - Updated default images: Postgres to `ghcr.io/multigres/pgctld:main`, Etcd to `gcr.io/etcd-development/etcd:v3.6.7`. - Added `livenessProbe` and `readinessProbe` to MultiAdmin container spec. - Updated `config/samples` to reflect new defaults and API structure. - **Logic**: - Updated `builders_global.go` to construct `MultiAdmin` with correct probes and arguments. - Implemented deterministic SHA-1 hashing for `TableGroup` names exceeding length limits. - Changed default shard name from `"0"` to `"0-inf"`. - **Testing**: - Fixed regression failures in `cluster-handler`, `resolver`, and `webhook` caused by naming changes. - Added `TestReconcileDatabases_BuildError_SchemeMismatch` to force `BuildTableGroup` error path coverage. - Added tests for `External` global topology resolution and `getGlobalTopoRef` error paths. - Achieved 100% test coverage across all modified modules.
This comment has been minimized.
This comment has been minimized.
🔬 Go Test Coverage ReportSummary
StatusDetailShow New Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
RootPathconfiguration for Etcd specs, updates default container images, and refines CRD definitions. Addresses resulting regressions in tests and adds comprehensive coverage for new paths.API/CRD:
rootPathfield to EtcdSpec (default:/multigres/global) inv1alpha1and CRDs.ghcr.io/multigres/pgctld:main, Etcd togcr.io/etcd-development/etcd:v3.6.7.livenessProbeandreadinessProbeto MultiAdmin container spec.config/samplesto reflect new defaults and API structure.Logic:
builders_global.goto constructMultiAdminwith correct probes and arguments.TableGroupnames exceeding length limits."0"to"0-inf".Testing:
cluster-handler,resolver, andwebhookcaused by naming changes.TestReconcileDatabases_BuildError_SchemeMismatchto forceBuildTableGrouperror path coverage.Externalglobal topology resolution andgetGlobalTopoReferror paths.