build(makefile): use stream editing for kustomize image replacement#130
Closed
fernando-villalba wants to merge 1 commit intomainfrom
Closed
build(makefile): use stream editing for kustomize image replacement#130fernando-villalba wants to merge 1 commit intomainfrom
fernando-villalba wants to merge 1 commit intomainfrom
Conversation
The `make kind-deploy` target was modifying config/manager/kustomization.yaml in-place, causing persistent git diffs and requiring manual reverts. This polluted the git status and risked accidental commits of ephemeral tags (and caused issues with rebases too) - Replaced `kustomize edit set image` with a `sed` stream replacement pipeline - Reset config/manager/kustomization.yaml image tag to `latest` - Applied this pattern to `deploy`, `kind-deploy`, `certmanager`, and `no-webhook` targets Ensures local development builds remain ephemeral and do not modify source control files.
🔬 Go Test Coverage ReportSummary
Status✅ PASS DetailShow New Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
make kind-deploytarget was modifyingconfig/manager/kustomization.yamlin-place, causing persistent git diffs and requiring manual reverts. This polluted the git status and risked accidental commits of ephemeral tags (and caused issues with rebases too)kustomize edit set imagewith asedstream replacement pipelinelatestdeploy,kind-deploy,certmanager, andno-webhooktargetsEnsures local development builds remain ephemeral and do not modify source control files.