feat(api): enforce overrides validation and expand tests#132
Merged
fernando-villalba merged 1 commit intomainfrom Jan 22, 2026
Merged
feat(api): enforce overrides validation and expand tests#132fernando-villalba merged 1 commit intomainfrom
fernando-villalba merged 1 commit intomainfrom
Conversation
The API previously allowed ambiguous configurations where both `spec` and `overrides` could be defined, and CEL validation rules lacked comprehensive testing coverage. - Added CEL rules to CellConfig and ShardConfig to strictly enforce mutual exclusion between `spec` and `overrides` - Renamed pkg/webhook/overrides_validation_test.go to pkg/webhook/cel_validation_test.go - Added comprehensive test cases for MultigresCluster, TopoServer, TableGroup, and Shard validation rules Eliminates configuration ambiguity and ensures 100% test coverage for all API validation logic.
🔬 Go Test Coverage ReportSummary
Status✅ PASS DetailShow New Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The API previously allowed ambiguous configurations where both
specandoverridescould be defined, and CEL validation rules lacked comprehensive testing coverage.specandoverridesEliminates configuration ambiguity and ensures 100% test coverage for all API validation logic.