Add utility metadata package for Kubernetes labels#18
Merged
Conversation
Collaborator
fernando-villalba
left a comment
fernando-villalba
left a comment
There was a problem hiding this comment.
As far as I can tell, it looks mostly perfect, just have two small questions about potential oversights.
Member
Author
|
@fernando-villalba With b2632ea, I moved all the tests into a separate package. There are a few more minor commits as well. If you could take another look, that would be appreciated! |
Member
Author
|
Going ahead with the merge, any impl adjustment can happen iteratively |
| // Parameters: | ||
| // - resourceName: The name of the custom resource instance (e.g., "my-etcd-cluster") | ||
| // - componentName: The component type (e.g., "etcd", "gateway", "orch", "pooler") | ||
| // - cellName: Optional cell name. If empty, no cell label is added. |
Collaborator
There was a problem hiding this comment.
Maybe remove this comment now we are doing a default?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a common label handling logic that will be used by many resources.