Merged
Conversation
rytswd
force-pushed
the
multi-go-module-setup
branch
from
f690bdc to
3c24a99
Compare
rcambrj
approved these changes
Oct 9, 2025
Collaborator
rcambrj
left a comment
rcambrj
left a comment
There was a problem hiding this comment.
Great work, only minor comments.
| **Controller Changes** (`pkg/{module}/controller/`): | ||
| - Run tests in the specific module: `cd pkg/resource-handler && go test ./...` | ||
| - Integration tests catch reconciliation bugs early | ||
| - Use `make run` for quick iteration (no docker build needed) |
Collaborator
There was a problem hiding this comment.
I realise that this line is unchanged - just pointing out that we should remember to create a Makefile with a run target :D
rytswd
commented
Oct 9, 2025
rcambrj
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces the multi Go module setup, where each module can have separate dependencies.
For local development, you can ensure LSP checks at one go.mod by opening at the module root directory, or use
go.workandgo workspacesetup to allow opening up from the repository root. There is some mention about Go workspace usage included in the document as well.NOTE: I have added test impl ofmain.go, as well asgo.workwhich is only meant to be used locally. This is just to demonstrate how we can handle the configuration, and that commit should be removed before this can be merged.This has been removed.