Skip to content

create local cluster deployment path #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rcambrj merged 1 commit into from
Oct 16, 2025
Merged

create local cluster deployment path #46

rcambrj merged 1 commit into from
Oct 16, 2025

Conversation

@rcambrj
Copy link
Collaborator

@rcambrj rcambrj commented Oct 16, 2025 •
edited
Loading

main goal: fixes make deploy

  • removes example (non-existent) role references
  • adds minikube to devshell
  • adds make minikube-load
  • renames default container image to something which kubernetes won't try to pull from network

@rcambrj rcambrj force-pushed the deploy-to-local-cluster branch from cd52c92 to 8b0ed6c Compare October 16, 2025 10:33
@rcambrj rcambrj changed the base branch from consume-multigateway-controller to main October 16, 2025 11:22
@rcambrj rcambrj force-pushed the deploy-to-local-cluster branch from 8b0ed6c to 73a8d6f Compare October 16, 2025 11:25
@fernando-villalba
Copy link
Collaborator

fernando-villalba commented Oct 16, 2025

This one is trying to solve a similar problem to this other PR:

https://github.com/numtide/multigres-operator/pull/45/files

fernando-villalba
fernando-villalba reviewed Oct 16, 2025
View reviewed changes
Copy link
Collaborator

@fernando-villalba fernando-villalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to this one: https://github.com/numtide/multigres-operator/pull/45/files

@rcambrj
Copy link
Collaborator Author

rcambrj commented Oct 16, 2025 •
edited
Loading

@fernando-villalba good one! I wish I'd known that this was happening. I think that both PRs add distinct value, since #45 is bringing up a KIND cluster and make deploy brings up the controller manager on your choice of cluster

@rcambrj rcambrj merged commit d2cd4d2 into main Oct 16, 2025
7 checks passed
@rcambrj rcambrj deleted the deploy-to-local-cluster branch October 16, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fernando-villalba fernando-villalba fernando-villalba approved these changes

@rytswd rytswd Awaiting requested review from rytswd

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rcambrj @fernando-villalba